Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Link collections #761

Merged
merged 3 commits into from
Jul 29, 2024
Merged

feat: Link collections #761

merged 3 commits into from
Jul 29, 2024

Conversation

LautaroPetaccio
Copy link
Contributor

This PR adds the capability to link collections to contracts.

@coveralls
Copy link

coveralls commented Jul 29, 2024

Pull Request Test Coverage Report for Build 10149395838

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 71.005%

Totals Coverage Status
Change from base Build 10096758936: 0.01%
Covered Lines: 3068
Relevant Lines: 4165

💛 - Coveralls

'urn:decentraland:amoy:collections-thirdparty:dcl-tests',
linked_contract_address: '0x02b6bD2420cCADC38726BD34BB7f5c52B3F4F3ff',
linked_contract_network: 'mainnet',
third_party_id: 'urn:decentraland:amoy:collections-thirdparty:dcl-tests',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be here mainnet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it!

@LautaroPetaccio LautaroPetaccio merged commit fe43e60 into master Jul 29, 2024
4 checks passed
@LautaroPetaccio LautaroPetaccio deleted the feat/link-collections branch July 29, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants