feat: add validation for the amount the tags being added #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LautaroPetaccio
approved these changes
Apr 4, 2024
src/Item/Item.service.ts
Outdated
| @@ -73,6 +74,16 @@ export class ItemService { | |||
| ) | |||
| : await Item.findOne<ItemAttributes>(item.id) | |||
|
|
|||
| if (item.data.tags.length > MAX_TAGS_LENGTH) { | |||
| const isAlreadyExcided = | |||
There was a problem hiding this comment.
Suggested change
| const isAlreadyExcided = | |
| const isAlreadyExceeded = |
src/Item/Item.service.spec.ts
Outdated
| }) | ||
| describe('and the item already has the maximun amount of tags', () => { | ||
| it('should throw the MaximunAmountOfTagsReachedError error', () => { | ||
| return expect(() => |
There was a problem hiding this comment.
The rejects modifier expects a promise, so It shouldn't be necessary to wrap the expectation on a function, would you mind removing it?
Suggested change
| return expect(() => | |
| return expect( |
Pull Request Test Coverage Report for Build 8567333208Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.