Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Store Smart Wearables video preview #675

Merged
merged 3 commits into from
Jul 7, 2023
Merged

feat: Store Smart Wearables video preview #675

merged 3 commits into from
Jul 7, 2023

Conversation

kevinszuchet
Copy link
Contributor

Closes #668
Closes #673

@kevinszuchet kevinszuchet requested a review from cyaiox July 6, 2023 11:31
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 6, 2023
View reviewed changes
src/Item/Item.router.ts Dismissed
*/
this.router.post(
'/items/:id/videos',
withAuthentication,

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is a rate limit? /s

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5474952451

  • 4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 70.058%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Item/Item.router.ts 4 6 66.67%
Totals Coverage Status
Change from base Build 5468081804: 0.04%
Covered Lines: 2793
Relevant Lines: 3834
💛 - Coveralls

@kevinszuchet kevinszuchet marked this pull request as ready for review July 6, 2023 15:01
cyaiox
cyaiox approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@cyaiox cyaiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kevinszuchet kevinszuchet merged commit 2127322 into master Jul 7, 2023
4 checks passed
@kevinszuchet kevinszuchet deleted the feat/store-sw-video-preview branch July 7, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyaiox cyaiox cyaiox approved these changes

Assignees

@kevinszuchet kevinszuchet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create logic to storeSW video Previews Fix S3 uploading thumbnails content-type
3 participants
@kevinszuchet @coveralls @cyaiox