feat: Add isApproved to the ThirdParty endpoint (#763)

* feat: Add isApproved to the ThirdParty endpoitng * fix: Tests * fix: Types
decentraland · Aug 9, 2024 · 77c0dfa · 77c0dfa
1 parent fe43e60
commit 77c0dfa
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 0 deletions.
diff --git a/spec/mocks/collections.ts b/spec/mocks/collections.ts
@@ -64,6 +64,7 @@ export const thirdPartyFragmentMock: ThirdPartyFragment = {
   id: dbTPCollectionMock.third_party_id,
   root: 'aRoot',
   managers: [wallet.address],
+  isApproved: true,
   maxItems: '10',
   metadata: {
     type: ThirdPartyMetadataType.THIRD_PARTY_V1,

diff --git a/src/ThirdParty/ThirdParty.router.spec.ts b/src/ThirdParty/ThirdParty.router.spec.ts
@@ -32,13 +32,15 @@ describe('ThirdParty router', () => {
       {
         id: '1',
         root: 'aRoot',
+        isApproved: true,
         managers: ['0x1'],
         maxItems: '3',
         metadata,
       },
       {
         id: '2',
         root: 'anotherRoot',
+        isApproved: true,
         managers: ['0x2', '0x3'],
         maxItems: '2',
         metadata,

diff --git a/src/ThirdParty/utils.spec.ts b/src/ThirdParty/utils.spec.ts
@@ -15,6 +15,7 @@ describe('toThirdParty', () => {
         root: 'aRoot',
         managers: ['0x1', '0x2'],
         maxItems: '1',
+        isApproved: true,
         metadata: {
           type: ThirdPartyMetadataType.THIRD_PARTY_V1,
           thirdParty: {
@@ -34,6 +35,7 @@ describe('toThirdParty', () => {
         root: fragment.root,
         managers: fragment.managers,
         maxItems: fragment.maxItems,
+        isApproved: true,
         name: name,
         description: description,
         contracts: [{ network: 'amoy', address: '0x0' }],
@@ -51,6 +53,7 @@ describe('toThirdParty', () => {
         root: 'aRoot',
         managers: ['0x2'],
         maxItems: '2',
+        isApproved: true,
         metadata: {
           type: ThirdPartyMetadataType.THIRD_PARTY_V1,
           thirdParty: null,
@@ -64,6 +67,7 @@ describe('toThirdParty', () => {
         root: fragment.root,
         managers: fragment.managers,
         maxItems: fragment.maxItems,
+        isApproved: fragment.isApproved,
         name: '',
         description: '',
         contracts: [],

diff --git a/src/ethereum/api/fragments.ts b/src/ethereum/api/fragments.ts
@@ -54,6 +54,7 @@ export const thirdPartyFragment = () => gql`
     root
     managers
     maxItems
+    isApproved
     metadata {
       type
       thirdParty {
@@ -168,6 +169,7 @@ export type CollectionFragment = {
 export type ThirdPartyFragment = {
   id: string
   root: string
+  isApproved: boolean
   managers: string[]
   maxItems: string
   metadata: ThirdPartyMetadata