Add checks for sorting versions #6088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
size: small
JKarlavige
commented
Sep 18, 2024
There was a problem hiding this comment.
This should always ensure the first & last versions are not booleans when passed into the sortVersions method.
JKarlavige
commented
Sep 18, 2024
There was a problem hiding this comment.
This is an additional check just in case a version is not a string before trying to split the string.
john-rock
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
On the live site, the following page is crashing: https://docs.getdbt.com/docs/use-dbt-semantic-layer/exports
The error is:
e.split is not a functionThis is occurring due to a check not being available when the
firstVersionprop is set on theVersionBlockcomponent without a version value:<VersionBlock firstVersion lastVersion="1.7">. This causes thefirstVersionto betrue. The newsortVersionsmethod then tries to use.split, which is not available for booleans.This PR adds two additional checks to ensure the
firstVersion(andlastVersion) are converted to the proper types before.splitis run when sorting the versions.Previews
Verify the page no longer crashes, and verify the
VersionBlockcomponents correctly show/hide content based on the selected version (page markdown here):https://docs-getdbt-com-git-fix-page-crash-dbt-labs.vercel.app/docs/use-dbt-semantic-layer/exports