Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dimensions.md #5217

Closed
wants to merge 2 commits into from
Closed

Update dimensions.md #5217

wants to merge 2 commits into from

Conversation

ialdg
Copy link
Contributor

@ialdg ialdg commented Apr 3, 2024

Hi.
This modification proposal has several added comments related mainly with the lack of certain parameters stated as "required" both for dimensions and measures, and also a possible typo related with the number of bulletpoints in a description. Regards.
IL.

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

Hi.
This modification proposal has several added comments related mainly with the lack of certain parameters stated as "required" both for dimensions and measures, and also a possible typo related with the number of bulletpoints in a description.
Regards.
IL.
@ialdg ialdg requested a review from a team as a code owner April 3, 2024 12:52
Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 4:22pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Apr 3, 2024
@mirnawong1 mirnawong1 self-assigned this Apr 5, 2024
@matthewshaver
Copy link
Contributor

Created as an issue to be addressed #5891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants