Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #656 #658

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

fix #656 #658

wants to merge 10 commits into from

Conversation

antonysouthworth-halter
Copy link
Contributor

@antonysouthworth-halter antonysouthworth-halter commented May 23, 2024 •
edited by nicor88
Loading

Description

fixes #656 #519

Models used to test - Optional

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@antonysouthworth-halter
Copy link
Contributor Author

WIP, added WITH NO DATA for SQL models, unsure exactly how to make this work for Spark/Python models.

@antonysouthworth-halter antonysouthworth-halter mentioned this pull request May 23, 2024
Open
@svdimchenko svdimchenko added the enable-functional-tests Label to trigger functional testing label May 28, 2024
@nicor88 nicor88 marked this pull request as ready for review May 28, 2024 17:19
nicor88
nicor88 reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@nicor88 nicor88 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, but I would like to see some functional testing for this issue.
Specifically might be possible to create a batch of data with no records, limiting the result to 0, e.g. select '1' as name limit 0

@nicor88
Copy link
Contributor

nicor88 commented May 28, 2024

@antonysouthworth-halter the functional tests are falling, please have a look 🙏🏻

@antonysouthworth-halter antonysouthworth-halter marked this pull request as draft June 12, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicor88 nicor88 nicor88 left review comments

@jessedobbelaere jessedobbelaere Awaiting requested review from jessedobbelaere

@Jrmyy Jrmyy Awaiting requested review from Jrmyy

@mattiamatrix mattiamatrix Awaiting requested review from mattiamatrix

@svdimchenko svdimchenko Awaiting requested review from svdimchenko

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enable-functional-tests Label to trigger functional testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] TABLE_NOT_FOUND {{tmp_relation}} when there are zero batches to process in incremental model
3 participants
@antonysouthworth-halter @nicor88 @svdimchenko