Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump dbt to 1.7.0 #488

Merged
merged 8 commits into from
Nov 9, 2023
Merged

chore: bump dbt to 1.7.0 #488

merged 8 commits into from
Nov 9, 2023

Conversation

nicor88
Copy link
Contributor

@nicor88 nicor88 commented Nov 3, 2023

Description

Bump dbt to 1.7.0 and see what we break, close #454

Added functional tests for dbt docs and macro overwride.

Breaking changes

dbt-labs/dbt-core#8846 is a pre-regression in 1.7.0rc1 that will be remediated for the final release of 1.7.0. The issue only impacts adapters that have overridden BaseAdapter.get_catalog() method. However, this does not affect adapters that have overridden the get_catalog(), macro.

Based on the code base we overwrite only get_catalog macro, but we don't overwrite, BaseAdapter.get_catalog(), but we overwrite a method that is called by get_catalog.

TODO

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@nicor88 nicor88 added the enable-functional-tests Label to trigger functional testing label Nov 3, 2023
@nicor88 nicor88 marked this pull request as draft November 3, 2023 14:12
svdimchenko
svdimchenko previously approved these changes Nov 6, 2023
@nicor88 nicor88 marked this pull request as ready for review November 6, 2023 15:29
dbt/adapters/athena/impl.py Outdated Show resolved Hide resolved
Copy link
Contributor

@svdimchenko svdimchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicor88 it's great you've added dbt-core 1.7.0 support! I've left just minor comments about commented out code

@nicor88
Copy link
Contributor Author

nicor88 commented Nov 8, 2023

@Jrmyy and @svdimchenko another review please 🙏🏻

Copy link
Contributor

@Jrmyy Jrmyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to add tests ✅

@nicor88 nicor88 merged commit 96e59d0 into main Nov 9, 2023
10 checks passed
@nicor88 nicor88 deleted the chore/bump_dbt_to_1_7 branch November 9, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enable-functional-tests Label to trigger functional testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to support dbt-core v1.7.0
3 participants