Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Don't use "DEBUG=1" for igr-tests in workflows #377

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

mobin-2008
Copy link
Collaborator

Signed-off-by: Mobin Aydinfar <[email protected]>

@mobin-2008 mobin-2008 added P-BSD Things related to BSD A-Importance: Low Issues such as harmless typos are included in this category. CI Things about CI/CD C-tests Things about unit or integration tests labels Sep 15, 2024
@davmac314
Copy link
Owner

Could you add to the commit message explaining why it's being removed? eg it has no effect anymore.

Because it does nothing since new igr-runner

Signed-off-by: Mobin Aydinfar <[email protected]>
@mobin-2008 mobin-2008 removed the P-BSD Things related to BSD label Sep 16, 2024
@mobin-2008 mobin-2008 changed the title CI: Don't use "DEBUG=1" for igr-tests in FreeBSD workflow CI: Don't use "DEBUG=1" for igr-tests in workflows Sep 16, 2024
@mobin-2008
Copy link
Collaborator Author

I did add a simple description to commit and eliminated all usage of DEBUG=1 in CI workflows (Not only FreeBSD one).

@mobin-2008 mobin-2008 merged commit ecd3514 into davmac314:master Sep 16, 2024
7 checks passed
@mobin-2008 mobin-2008 deleted the dont_set_debug_cirrus_ci branch September 16, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Importance: Low Issues such as harmless typos are included in this category. C-tests Things about unit or integration tests CI Things about CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants