CI: Fix grammar and mark MacOS workflow as ARM64 not x86_64 #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobin-2008
added
A-Importance: Low
davmac314
reviewed
Jul 24, 2024
Looks like GitHub now uses aarch64 machines for MacOS workflows according to this document: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#standard-github-hosted-runners-for-public-repositories Signed-off-by: Mobin Aydinfar <[email protected]>
mobin-2008
force-pushed
the
fix_ci_misleading
branch
from
9dddab1
to
0b08ca4
Compare
davmac314
approved these changes
Jul 24, 2024
mobin-2008
added a commit
to mobin-2008/dinit
that referenced
this pull request
Sep 8, 2024
Same as davmac314#355, I forgot to fix in meson_ci.yml Signed-off-by: Mobin Aydinfar <[email protected]>
mobin-2008
added a commit
that referenced
this pull request
Sep 8, 2024
Same as #355, I forgot to fix in meson_ci.yml Signed-off-by: Mobin Aydinfar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like GitHub now uses arm64 machines for MacOS workflows.
Signed-off-by: Mobin Aydinfar <[email protected]>