Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialize set and frozenset #72

Merged
merged 2 commits into from
Aug 10, 2024
Merged

serialize set and frozenset #72

merged 2 commits into from
Aug 10, 2024

Conversation

davidhewitt
Copy link
Owner

Long overdue merge of #39

Thanks @LilyFoote and sorry this took so long to actually see across the line. I went for a slightly different approach to avoid the potential of infinite iterators and only accept existing sequences plus the new set/frozenset options.

Closes #39

@davidhewitt
Copy link
Owner Author

Immediately upon hitting the flaky test error due to sets being unordered and conflicting with an inhomogeneous tuple of type (String, i32), I've narrowed this so that we only allow deserializing into homogeneous sequence containers like Vec, and not tuples.

@davidhewitt davidhewitt merged commit 992cdad into main Aug 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant