Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #175 : if concurrency and ordered, warn. #200

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Fix #175 : if concurrency and ordered, warn. #200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9321ac0
Fix #175 : if concurrency and ordered, warn.
erichare Feb 8, 2024
3c2a726
Merge branch 'master' into bugfix/175-warning-ordered
hemidactylus Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions astrapy/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,6 +770,12 @@ def chunked_insert_many(
"""
results: List[Union[API_RESPONSE, Exception]] = []

# Raise a warning if ordered and concurrency
if options and options.get("ordered") is True and concurrency > 1:
logger.warning(
"Using ordered insert with concurrency may lead to unexpected results."
)

# If we have concurrency as 1, don't use a thread pool
if concurrency == 1:
# Split the documents into chunks
Expand Down
Loading