rework upsert flow to handle all errors from API #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amorton FYI, and thank you for surfacing this missing error handling in the flow! |
cbornet
reviewed
Jan 15, 2024
tests/astrapy/test_async_db_dml.py
Outdated
| "$vector": [10, 11, 999, -153], | ||
| } | ||
| with pytest.raises(ValueError): | ||
| _ = await async_writable_vector_collection.upsert(document0b) |
There was a problem hiding this comment.
Suggested change
| _ = await async_writable_vector_collection.upsert(document0b) | |
| await async_writable_vector_collection.upsert(document0b) |
cbornet
reviewed
Jan 15, 2024
tests/astrapy/test_async_db_dml.py
Outdated
| "$vector": [10, 11, 999, -153], | ||
| } | ||
| with pytest.raises(ValueError): | ||
| _ = await async_writable_vector_collection.upsert(document1) |
There was a problem hiding this comment.
Suggested change
| _ = await async_writable_vector_collection.upsert(document1) | |
| await async_writable_vector_collection.upsert(document1) |
cbornet
reviewed
Jan 15, 2024
tests/astrapy/test_db_dml.py
Outdated
| "$vector": [10, 11, 999, -153], | ||
| } | ||
| with pytest.raises(ValueError): | ||
| _ = writable_vector_collection.upsert(document0b) |
There was a problem hiding this comment.
Suggested change
| _ = writable_vector_collection.upsert(document0b) | |
| writable_vector_collection.upsert(document0b) |
cbornet
reviewed
Jan 15, 2024
tests/astrapy/test_db_dml.py
Outdated
| "$vector": [10, 11, 999, -153], | ||
| } | ||
| with pytest.raises(ValueError): | ||
| _ = writable_vector_collection.upsert(document1) |
There was a problem hiding this comment.
Suggested change
| _ = writable_vector_collection.upsert(document1) | |
| writable_vector_collection.upsert(document1) |
erichare
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159 .
The errors in CI (apart from timeouts and such) are due to the "ordered=false" default - unrelated to this PR - #169 takes care of them.