Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(query): use pipeline exchange to refactor window scatter #16471

Merged
merged 5 commits into from
Sep 20, 2024
Merged

refactor(query): use pipeline exchange to refactor window scatter #16471

merged 5 commits into from
Sep 20, 2024
+208 −339

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Sep 19, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor(query): use pipeline exchange to refactor window scatter

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@zhang2014 zhang2014 marked this pull request as draft September 19, 2024 09:42
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 19, 2024
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 19, 2024
@dosubot dosubot bot added the A-query Area: databend query label Sep 19, 2024
@zhang2014 zhang2014 marked this pull request as ready for review September 19, 2024 13:51
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 19, 2024
@zhang2014 zhang2014 added the ci-benchmark Benchmark: run all test label Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-16471-1e3eae1-1726757806

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@zhang2014 zhang2014 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-16471-bab73b1-1726763263

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

Dousir9
Dousir9 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@Dousir9 Dousir9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the performance test on Databend Cloud also passed.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 20, 2024
@zhang2014 zhang2014 added this pull request to the merge queue Sep 20, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 20, 2024
@BohuTANG BohuTANG merged commit af6c418 into datafuselabs:main Sep 20, 2024
78 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dousir9 Dousir9 Dousir9 approved these changes

Assignees
No one assigned
Labels
A-query Area: databend query ci-benchmark Benchmark: run all test lgtm This PR has been approved by a maintainer pr-refactor this PR changes the code base without new features or bugfix size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhang2014 @Dousir9 @BohuTANG