refactor: dropped table listing and GC #16531
Merged
+143
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
commented
Sep 26, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @drmingdrmer)
drmingdrmer
force-pushed
the
142-yy
branch
2 times, most recently
from
ec12a7b
to
4cebd0f
Compare
- Replace `TableInfoFilter` with `Range<Option<DateTime<Utc>>>` for more flexible filtering - Simplify `ListDroppedTableReq` struct and add builder methods - Update schema_api_impl and tests to use new ListDroppedTableReq API - Adjust vacuum logic in interpreter_vacuum_drop_tables to use new API - Minor code cleanup and documentation improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: dropped table listing and GC
TableInfoFilterwithRange<Option<DateTime<Utc>>>for more flexible filteringListDroppedTableReqstruct and add builder methodsTests
Type of change
Related Issues
This change is