Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): Initial implementation of postgres-compatible number to_char function #16507

Merged
merged 9 commits into from
Sep 26, 2024
Merged

feat(query): Initial implementation of postgres-compatible number to_char function #16507

merged 9 commits into from
Sep 26, 2024
+1,280 −0

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Sep 24, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

link #16480

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@forsaken628
num_to_char
dcadede 
Signed-off-by: coldWater <[email protected]>
@forsaken628
i32_to_char
4853c88 
Signed-off-by: coldWater <[email protected]>
@forsaken628
clean up
c3925e7 
Signed-off-by: coldWater <[email protected]>
@forsaken628
register
9b6b0ac 
Signed-off-by: coldWater <[email protected]>
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Sep 24, 2024
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Sep 24, 2024
@dosubot dosubot bot added the A-query Area: databend query label Sep 24, 2024
@forsaken628
test
930cf96 
Signed-off-by: coldWater <[email protected]>
@forsaken628
f64_to_num_part
a29d4dd 
Signed-off-by: coldWater <[email protected]>
@forsaken628
test
86b831c 
Signed-off-by: coldWater <[email protected]>
@forsaken628
SG PL MI
21a165d 
Signed-off-by: coldWater <[email protected]>
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Sep 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 26, 2024
@forsaken628
fix
705a867 
Signed-off-by: coldWater <[email protected]>
@forsaken628 forsaken628 added this pull request to the merge queue Sep 26, 2024
@forsaken628 forsaken628 mentioned this pull request Sep 26, 2024
Open
14 tasks
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@forsaken628 forsaken628 added this pull request to the merge queue Sep 26, 2024
Merged via the queue into databendlabs:main with commit 99e039f Sep 26, 2024
71 checks passed
@forsaken628 forsaken628 deleted the num_to_char branch September 26, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
A-query Area: databend query lgtm This PR has been approved by a maintainer pr-feature this PR introduces a new feature to the codebase size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forsaken628 @sundy-li