Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table_function): table_function inspect_parquet(s) #13214

Merged
merged 28 commits into from
Oct 26, 2023

Conversation

zenus
Copy link
Contributor

@zenus zenus commented Oct 11, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR


This change is Reviewable

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 1:20pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

This pull request's title is not fulfill the requirements. @zenus please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@zenus zenus changed the title feature: table_function inspect_parquet(s) feat(table_function): table_function inspect_parquet(s) Oct 12, 2023
@zenus
Copy link
Contributor Author

zenus commented Oct 17, 2023

Test finished, fail fast enabled, 1 out of 153 records failed to run
0: query failed: mysql client error: Server error: `ERROR HY000 (1105): BadArguments. Code: 1006, Text = stage path must start with @, but got data/parquet/tuple.parquet.'
[SQL] select * from inspect_parquet('@data/parquet/tuple.parquet')
at tests/sqllogictests/suites/stage_parquet/inspect_parquet:1

could you please help me solve this error? I've been confused by it for a hour.

@youngsofun
Copy link
Member

rest LGTM.

@BohuTANG BohuTANG merged commit 983d3d2 into databendlabs:main Oct 26, 2023
60 checks passed
@BohuTANG
Copy link
Member

Thanks for the contribution.

@BohuTANG
Copy link
Member

Ping @soyeric128 for documents about this new table function, thanks.

andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
…#13214)

* add table function inspect_parquet

* add new feature

* update test case

* fix path

* fix

* fixed

* fixed

* add fix

* fixed

* fixed

* fix test

* add fix

* add fixed

* fixed

* Update src/query/service/src/table_functions/inspect_parquet/inspect_parquet_table.rs

Co-authored-by: Yang Xiufeng <[email protected]>

* fixed

* fixed

* Update inspect_parquet

* optimized

* add

* fixed

* fix test case

---------

Co-authored-by: Yang Xiufeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: table_function inspect_parquet(s)
3 participants