Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tables.py test #609

Closed
wants to merge 1 commit into from
Closed

tables.py test #609

wants to merge 1 commit into from

Conversation

add-itya
Copy link

[X] Wrote test for feature
[ ] Added changes to CHANGELOG.md

Changes proposed:
I added functionality to check column entry types are consistent. I saw that there are functions that check the values of the basic tables, and thought it would be nice to add a check for their types. Please let me know if anything is missing, thanks :)

@adnanhemani
Copy link
Member

Hi @add-itya - given that the columns are a NumPy array, it is pretty much a requirement that they have the same object types. Given that, I'm inclined to close this PR, as it is unlikely that there is any change related here that may still be useful to the repo.

Did you see any test coverage that is not covered without this check? I'm glad to take a look if that's the case - I wasn't able to verify quickly as the GitHub Action above (which runs the test suite and coverage checker) failed. Please take a look at that if you think this change still helps with the code coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants