-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fixes and improvements for feature_llmq_simplepose.py
#6287
Conversation
6278 merged |
9dbeaa5
to
a656d2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ACK a656d2f
just some semi-relevant feedback on PR CI: only one failure out of 5 (for linux64-multiprocess): https://gitlab.com/dashpay/dash/-/jobs/7917711153
I run this version on my laptop in many threads and observed various different failures: Beside 40 successful runs I noticed these failures,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK a656d2f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK a656d2f
Issue being fixed or feature implemented
Fix some general mistakes and also
connect_nodes
related issues discovered while debugging #6276. Add some logging to make debugging a bit easier.NOTE: builds on top of #6278 to avoid conflicts, will rebasedoneWhat was done?
pls see individual commits
How Has This Been Tested?
run tests
Breaking Changes
n/a
Checklist: