feat(rpc): introduce and use setmnthreadactive (regtest-only)
#6286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvg
approved these changes
Sep 25, 2024
knst
reviewed
Sep 26, 2024
| { | ||
|
|
||
| if (Params().NetworkIDString() != CBaseChainParams::REGTEST) { | ||
| throw std::runtime_error("setmnthreadactive is for regression testing (-regtest mode) only."); |
There was a problem hiding this comment.
should not it be JSONRPCError?
There was a problem hiding this comment.
For whatever reason all such messages are thrown this way 🤷♂️
https://github.com/search?q=repo%3Abitcoin%2Fbitcoin+%22%28-regtest+mode%29%22&type=code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This adds a new rpc command to enable/disable automatic masternode connections creation. We need this for #6276. 1e17b74 is extracted from ede1833 to avoid multiple jobs calling
setmnthreadactiveon the same node in parallel.What was done?
Add
setmnthreadactiverpc and use itHow Has This Been Tested?
run tests
Breaking Changes
n/a
Checklist: