fix: new fork 'withdrawals' and fixes for asset unlock signature verification #6279
+137
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
force-pushed
the
fix-withdrawal-quorums
branch
from
7b33395
to
1870106
Compare
knst
changed the title
thephez
reviewed
Sep 23, 2024
Comment on lines
+213
to
+214
| consensus.vDeployments[Consensus::DEPLOYMENT_WITHDRAWALS].nStartTime = 1704067200; // January 1, 2024 | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_WITHDRAWALS].nTimeout = 1767225600; // January 1, 2026 |
There was a problem hiding this comment.
Start time and timeout values for each network should be updated to something more relevant before merging
|
This pull request has conflicts, please rebase. |
|
Needs rebase? |
it depends on #6275 (bury mn_rr) also, which is not merged yet; will rebase after |
knst
force-pushed
the
fix-withdrawal-quorums
branch
from
b5237f3
to
4a473a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it includes also changes from
#6269#6275 to reduce conflicts in futureIssue being fixed or feature implemented
https://github.com/dashpay/dash-issues/issues/83
What was done?
Introduces new fork "withdrawals" which let Asset Unlock be valid for any active quorum + 1 extra inactive (in opposite of hard-coded 2 of them).
How Has This Been Tested?
See new test section
test_withdrawals_forkin functional test feature_asset_locks.pyBreaking Changes
Checklist: