Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: merge bitcoin#22817, #23042, #22777, #25443, #26138, #26854, #27128, #27761, #27863, #28287, partial bitcoin#22778 (auxiliary backports: part 16) #6276

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from
Draft

backport: merge bitcoin#22817, #23042, #22777, #25443, #26138, #26854, #27128, #27761, #27863, #28287, partial bitcoin#22778 (auxiliary backports: part 16) #6276

wants to merge 14 commits into from
+237 −73

Commits on Sep 30, 2024

  1. test: don't attempt to (dis)connect nodes to/from themselves

    @kwvg
    kwvg committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    5081642 View commit details
    Browse the repository at this point in the history

  2. test: don't attempt to reconnect already connected nodes

    @kwvg
    kwvg committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    4d9bb17 View commit details
    Browse the repository at this point in the history

  3. merge bitcoin#22817: Avoid race after connect_nodes 

    Due to stricter checks, we can no longer start masternodes in parallel,
as entities used to process `to_connection` checks are reused before the
previous check is completed, resulting in an exception. Since we're
now validating the establishment of a two-way connection, we have to do
it one at a time.
    @kwvg
    kwvg committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c6fb61f View commit details
    Browse the repository at this point in the history

  4. merge bitcoin#23042: Avoid logging AlreadyHaveTx when disconnecting m… 

    …isbehaving peer
    @kwvg
    kwvg committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    008286e View commit details
    Browse the repository at this point in the history

  5. merge bitcoin#22777: don't request tx relay on feeler connections

    @kwvg
    kwvg committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    62ffd8d View commit details
    Browse the repository at this point in the history

  6. partial bitcoin#22778: Reduce resource usage for inbound block-relay-… 

    …only connections

includes:
- 290a8da
    @kwvg
    kwvg committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f7f9a74 View commit details
    Browse the repository at this point in the history

  7. merge bitcoin#25443: Fail if connect_nodes fails

    @kwvg
    kwvg committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    4cc6625 View commit details
    Browse the repository at this point in the history

  8. merge bitcoin#26138: Avoid race in disconnect_nodes helper

    @kwvg
    kwvg committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8f37569 View commit details
    Browse the repository at this point in the history

  9. merge bitcoin#26854: Fix intermittent timeout in p2p_permissions.py

    @kwvg
    kwvg committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b669336 View commit details
    Browse the repository at this point in the history

  10. merge bitcoin#27128: fix intermittent issue in p2p_disconnect_ban

    @kwvg
    kwvg committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9a0956f View commit details
    Browse the repository at this point in the history

  11. merge bitcoin#27761: Log addresses of stalling peers

    @kwvg
    kwvg committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8f4cbec View commit details
    Browse the repository at this point in the history

  12. merge bitcoin#27863: do not break when addr is not from a distinct ne… 

    …twork group
    @kwvg
    kwvg committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    923883f View commit details
    Browse the repository at this point in the history

  13. fix: ensure that deadlocks are actually resolved 

    The fix introduced in bitcoin#27981 (8c986d6, dash#6067) is not
validated to work until bitcoin#28287, an upcoming backport.

As the latter has identified the former backport didn't pass validation,
let's fix it so that the latter tests succeed when they're backported
in an upcoming commit.
    @kwvg
    kwvg committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    76f4bcb View commit details
    Browse the repository at this point in the history

  14. merge bitcoin#28287: add sendmsgtopeer rpc and a test for net-level… 

    … deadlock situation

`random_bytes()` is introduced in bitcoin#25625 but the function def
alone doesn't warrant a full backport, so we'll only implement the
section relevant to this PR.
    @kwvg
    kwvg committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d8ce4b7 View commit details
    Browse the repository at this point in the history