backport: bitcoin#23590, 23258, 23061, 23694 #6256
Open
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hecks fails faad05c Crash debug builds when mempool ConsensusScriptChecks fails (MarcoFalke) Pull request description: Currently a bug in the function might sneak around our testing infrastructure. Fix that by turning bugs into crashes during tests. ACKs for top commit: glozow: utACK faad05c, there's something seriously wrong with the code if this returns false, good to throw in debug mode Tree-SHA512: dfea1cd9ce3f1c303f49cca1417cd5c77c6ed12849aaff7b6ab1b6060f2f0c9cf5d4689017355d11f66639bab35823f65f848e6979042fa875181509dfd5d3d7
vijaydasmp
changed the title
vijaydasmp
changed the title
vijaydasmp
changed the title
|
Hello @UdjinM6 requesting review |
UdjinM6
previously approved these changes
Sep 11, 2024
|
Hello @PastaPastaPasta, @knst , requesting review |
knst
requested changes
Sep 24, 2024
src/wallet/wallet.cpp
Outdated
| @@ -1366,7 +1366,7 @@ void CWallet::updatedBlockTip() | |||
| void CWallet::BlockUntilSyncedToCurrentChain() const { | |||
| AssertLockNotHeld(cs_wallet); | |||
| // Skip the queue-draining stuff if we know we're caught up with | |||
| // chainActive.Tip(), otherwise put a callback in the validation interface queue and wait | |||
| // chain.Tip(), otherwise put a callback in the validation interface queue and wait | |||
There was a problem hiding this comment.
23258: nit: missing parenthesis
chain -> chain()
doc/release-notes-23061.md
Outdated
Comment on lines
1
to
5
| - In previous releases, the meaning of the command line option | ||
| `-persistmempool` (without a value provided) incorrectly disabled mempool | ||
| persistence. `-persistmempool` is now treated like other boolean options to | ||
| mean `-persistmempool=1`. Passing `-persistmempool=0`, `-persistmempool=1` | ||
| and `-nopersistmempool` is unaffected. (#) |
…ctive() a0efe52 Fix outdated comments referring to ::ChainActive() (Samuel Dobson) Pull request description: After bitcoin#21866 there are a few outdated comments referring to `::ChainActive()`, which should instead refer to `ChainstateManager::ActiveChain()`. ACKs for top commit: jamesob: ACK bitcoin@a0efe52 Tree-SHA512: 80da19c105ed29ac247e6df4c8e916c3bf3f37230b63f07302114eef9c115add673e9649f0bbe237295be0c6da7b1030b5b93e14daf6768f17ce5de7cf2c9ff2
faa9c19 doc: Add 23061 release notes (MarcoFalke) faff17b Fix (inverse) meaning of -persistmempool (MarcoFalke) Pull request description: Passing `-persistmempool` is currently treated as `-nopersistmempool` ACKs for top commit: jnewbery: reACK faa9c19 hebasto: ACK faa9c19, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: f34a89a07745dabe340eb845b2a348b79c093e9056f7a21c17e1ba2e278177c9b4cf30e8095791fd645a7f90eb34850b2eee0c869b4f6ec02bf749c73b0e52ee
…tion fa1571b doc: Add missing optional to MempoolEntryDescription (MarcoFalke) Pull request description: Needed for bitcoin#23083. Can be reviewed with `--word-diff-regex=.`. ACKs for top commit: josibake: ACK bitcoin@fa1571b shaavan: ACK fa1571b Tree-SHA512: b4370003d2aeadce438778e15bd9a0d6a7fef4711acbe8471a50a9d72bbf74e1705fecbaae6f7eb367ece7c795a816c4b8b6583ed6c8f91b35621ca30fd95c18
vijaydasmp
force-pushed
the
bp23_2024_09_01
branch
from
376cb95
to
65821b9
Compare
|
Hello @knst , requesting review |
UdjinM6
approved these changes
Sep 27, 2024
knst
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more bitcoin backports