-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix test of withdrawal for more than 1000 dash #6141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls check 2bbf41f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 4f0f22d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 4f0f22d; only changes tests
bcdb696
to
2d2c05a
Compare
rebased via GH GUI to fix "Check Merge Fast-Forward Only" |
It's now not signed so I can't merge it ;) |
well, that's better than merging a broken one anyway :D |
Now function test doesn't distint difference between 10% or 1000. Adjust amounts to make it less than 10% but more than 1000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK f22ade3
Issue being fixed or feature implemented
DIP for Credit Pool says:
Though, current functional test for asset locks improperly test this case, because threshold for big withdrawal happens by 10%, not 1000 dash.
What was done?
Improvements for functional asset lock test to actually test a limit 1000 dash, not just 10%
How Has This Been Tested?
See changes
Breaking Changes
N/A, changes only for tests
Checklist: