-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport: merge bitcoin#23909, #23778, #24495,#25313, #24042, #24057, #24348, #24484, #24489, #24599, #24503, #24506, #24573, #25779, #24736, #24842, #25006, #25076, #25490, #25558 (guix backports: part 2) #5408
Conversation
01b8316
to
36b3f7f
Compare
This pull request has conflicts, please rebase. |
028abc7
to
62d80b2
Compare
This pull request has conflicts, please rebase. |
2bc1dc7
to
306411e
Compare
Build outputBinaries:
Archives:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit review utACK for merging via merge commit; doing aarch64 guix build now
contrib/guix/guix-build
Outdated
@@ -239,7 +239,7 @@ SOURCE_DATE_EPOCH="${SOURCE_DATE_EPOCH:-$(git log --format=%at -1)}" | |||
time-machine() { | |||
# shellcheck disable=SC2086 | |||
guix time-machine --url=https://git.savannah.gnu.org/git/guix.git \ | |||
--commit=6ba510d76d6847065be725e958718002f3b13c7a \ | |||
--commit=1ef7a03a148cf5f83ab1820444f6bd50d8e732d1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a note for re-review:
extra changes in contrib/guix/manifest.scm
already presented:
+ (substitute* "tests/test_validate.py"
+ (("^(.*)def test_revocation_mode_soft" line indent)
+ (string-append indent
+ "@unittest.skip(\"Disabled by Guix\")\n"
+ line)))
In bitcoin they are removed in Merge bitcoin#24503: guix: use the latest version of signapple
but re-added in Merge bitcoin#25779: guix: ignore additional failing certvalidator test
So, backport is NOT partial, we already have both these backports merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hashes match and gitian still works.
side note: let's use checksum scripts which would let us all have the same output (and which would match guix github workflow results too) i.e.:
# for binaries
( \
SRC_PATH_PREFIX=guix-build-$(git rev-parse --short=12 HEAD)/distsrc- && \
sha256sum ${SRC_PATH_PREFIX}*/src/dash{d,-cli,-tx,-wallet}{,.exe} && \
sha256sum ${SRC_PATH_PREFIX}*/src/qt/dash-qt{,.exe} && \
sha256sum ${SRC_PATH_PREFIX}*/src/test/test_dash{,.exe} \
) | LC_ALL=C sort -k 2
# for archives
find guix-build-"$(git rev-parse --short=12 HEAD)"/output -type f | grep -v SHA256 | xargs sha256sum | LC_ALL=C sort -k 2
Added two commits instead of integrating them into backport PR and haven't rebased upon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
UPD: hashes also matched
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed that osx gitian still works
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
light-ACK for merging via merge commit
…0 as minimum supported
Additional Information