forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Merklerootmnlist calc bls scheme (#5157)
## Issue being fixed or feature implemented Code was still using legacy scheme for `pubKeyOperator` of each `CSimplifiedMNListEntry` while calculating `MerklerootMNList` while v19 HF was active. ## What was done? When building `CSimplifiedMNList` for `MerklerootMNList`, this PR adds the correct set of `nVersion` for `CSimplifiedMNListEntry` so that basic scheme will be used instead of legacy. Furthermore, DIP3 unit tests suites for v19 will test for 1000 blocks instead of 900 to cover v19 activated period. ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation **For repository code-owners and collaborators only** - [x] I have assigned this pull request to a milestone
- Loading branch information
1 parent
26cc723
commit e7e4832
Showing
4 changed files
with
11 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters