forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge #6239: feat: increase the number of block headers able to be do…
…wnloaded at once to 8000 in protocol version `70235` 48c7f98 doc: drop trailing whitespace (pasta) 697743d test: add missing import (UdjinM6) cfe99fd docs: add release notes for 6239 (pasta) a6bbaac fix: GetHeadersLimit is used for getheaders(2) and headers(2), refactor it to accept `compressed` instead of `msg_type` (UdjinM6) b224f3f bump p2p_version in tests (PastaPastaPasta) b423f42 refactor: sort imports (UdjinM6) f6c68ba refactor: simplify _compute_requested_block_headers (UdjinM6) 07876b2 use `MAX_HEADERS_UNCOMPRESSED_RESULT` not `MAX_HEADERS_UNCOMPRESSED_RESULTS` ; use `MAX_HEADERS_UNCOMPRESSED_RESULT` in RPC to avoid breaking changes (pasta) b137280 change to _COMPRESSED or _UNCOMPRESSED (pasta) 303bc7a fix: increase it for headers2 only (UdjinM6) e23410f trivial: rename `MAX_HEADERS_RESULTS_NEW` to `MAX_HEADERS_RESULTS` (Kittywhiskers Van Gogh) bcf0320 trivial: move the headers limit determination to `GetHeadersLimit()` (Kittywhiskers Van Gogh) 993c7c0 feat: increase the number of block headers able to be downloaded at once to 8000 in protocol version `70234` (pasta) Pull request description: ## Issue being fixed or feature implemented We did some testing quite a while ago that found that sending 8000 headers at a time could speed stuff up. But we wanted to wait until compressed headers were implemented. Well, they've been implemented! ## What was done? Bump 2000 -> 8000 triggered by protocol version ## How Has This Been Tested? Hasn't, we should setup a few nodes running this and sync them from each other ## Breaking Changes New protocol version, not breaking but should add notes? I should probably add release notes ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: light ACK 48c7f98 knst: utACK 48c7f98 Tree-SHA512: 54c68b9496131ab7f32504d44398d776a151df809d0120d093bbabb18904a783bd9b58796820209f5d75552df5476e30eaa09d68f7c5057882f94b5766a64f4c
- Loading branch information
Showing
8 changed files
with
53 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
P2P and Network Changes | ||
----------------------- | ||
|
||
The max number of compressed block headers which can be requested at once has been increased from 2000 to 8000. This | ||
change activates with the protocol version `70235` and only applies to compressed block headers. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters