fix: #389 [macOS] Terminating app due to uncaught exception 'NSIntern…

[potatojoayo]

Issue

#389 [macOS] Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'dismissViewController:: Error: maybe this view controller was not presented?'

Cause

webView function in FacebookAuthDesktopPlugin class was calling dismiss(self). It threw the exception that the function was trying to dismissViewController which is not presented (or already closed; maybe it was being called twice).

Solution

Instead of calling dismiss(self), created var window: NSWindow? and set self.view.window of the WebViewController as below.

public override func viewDidAppear() {
        window = self.view.window!
    } 

Then replace dismiss(self) with window?.performClose(nil) in webView function.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e8d308) 96.77% compared to head (f4e3c13) 96.77%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files           6        6           
  Lines          93       93           
=======================================
  Hits           90       90           
  Misses          3        3           

[darwin-morocho]

@potatojoayo thanks for your PR