Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getters and setters actually look like their declarations #3858

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

srawlins
Copy link
Member

Fixes #1846, almost 6 years old! 😬

Here's a screenshot of what the new signatures look like, with get and set (I hate that the single parameter on the setter gets newlined, but that's a different issue. Maybe track #3721 for that one.

Screenshot 2024-08-30 at 9 47 25 AM
  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins
Copy link
Member Author

CC @dart-lang/analyzer-team

Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@srawlins srawlins merged commit 46564a6 into dart-lang:main Sep 2, 2024
9 checks passed
@srawlins srawlins deleted the get-and-set branch September 2, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dartdoc renders property setters in a nonsensical manner
2 participants