Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interfaces: Update all component interfaces to implement io.Closer #3542

Merged
merged 15 commits into from
Sep 19, 2024

Commits on Sep 18, 2024

  1. Interfaces: Update all component interfaces to implement io.Closer

    Previously, component interfaces did not mandate the implementation of
    the io.Closer interface and instead components could optionally
    implement `Close() error` or not. This meant that consumers had to
    manually type check if a component implemented `io.Closer` or not when
    attempting to close a component.
    
    This lead to situations whereby components either didn't implement the
    func signature correctly, like in the case of the [mongodb state
    store](https://github.com/dapr/components-contrib/pull/3537/files), or
    components had leakage where resources were not being closed properly as
    there was no close shutdown method.
    
    All components now implement the `io.Closer` interface.
    
    The configuration components have been updated to correctly respect
    contexts, and correctly wait for resources to be released on Close.
    
    Signed-off-by: joshvanl <[email protected]>
    JoshVanL committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    748ace1 View commit details
    Browse the repository at this point in the history
  2. Linting

    Signed-off-by: joshvanl <[email protected]>
    JoshVanL committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d5f2b16 View commit details
    Browse the repository at this point in the history
  3. Fix obs mock interface

    Signed-off-by: joshvanl <[email protected]>
    JoshVanL committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3962972 View commit details
    Browse the repository at this point in the history
  4. Fix appconfig unit test

    Signed-off-by: joshvanl <[email protected]>
    JoshVanL committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f804e4a View commit details
    Browse the repository at this point in the history
  5. Lint

    Signed-off-by: joshvanl <[email protected]>
    JoshVanL committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6316d66 View commit details
    Browse the repository at this point in the history
  6. Update cert test dapr/dapr to main with updated io.Closer

    Signed-off-by: joshvanl <[email protected]>
    JoshVanL committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    10bde67 View commit details
    Browse the repository at this point in the history
  7. Adds healthz to runtime config

    Signed-off-by: joshvanl <[email protected]>
    JoshVanL committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2b5fbee View commit details
    Browse the repository at this point in the history
  8. Adds logger to metrics

    Signed-off-by: joshvanl <[email protected]>
    JoshVanL committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f711630 View commit details
    Browse the repository at this point in the history
  9. Fix nil Security on runtime config

    Signed-off-by: joshvanl <[email protected]>
    JoshVanL committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4e934bc View commit details
    Browse the repository at this point in the history
  10. Adds unit tags to certification workflow file

    Signed-off-by: joshvanl <[email protected]>
    JoshVanL committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    555ce7f View commit details
    Browse the repository at this point in the history
  11. Chain go test tags in workflow

    Signed-off-by: joshvanl <[email protected]>
    JoshVanL committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7881ba9 View commit details
    Browse the repository at this point in the history
  12. TODO

    Signed-off-by: joshvanl <[email protected]>
    JoshVanL committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    702899e View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Fix redis configuration Close

    Signed-off-by: joshvanl <[email protected]>
    JoshVanL committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2bb2a06 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    65556ae View commit details
    Browse the repository at this point in the history
  3. Adds Close() error to echo conversation

    Signed-off-by: joshvanl <[email protected]>
    JoshVanL committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    db30576 View commit details
    Browse the repository at this point in the history