-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interfaces: Update all component interfaces to implement io.Closer #3542
Commits on Sep 18, 2024
-
Interfaces: Update all component interfaces to implement io.Closer
Previously, component interfaces did not mandate the implementation of the io.Closer interface and instead components could optionally implement `Close() error` or not. This meant that consumers had to manually type check if a component implemented `io.Closer` or not when attempting to close a component. This lead to situations whereby components either didn't implement the func signature correctly, like in the case of the [mongodb state store](https://github.com/dapr/components-contrib/pull/3537/files), or components had leakage where resources were not being closed properly as there was no close shutdown method. All components now implement the `io.Closer` interface. The configuration components have been updated to correctly respect contexts, and correctly wait for resources to be released on Close. Signed-off-by: joshvanl <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 748ace1 - Browse repository at this point
Copy the full SHA 748ace1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5f2b16 - Browse repository at this point
Copy the full SHA d5f2b16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3962972 - Browse repository at this point
Copy the full SHA 3962972View commit details -
Configuration menu - View commit details
-
Copy full SHA for f804e4a - Browse repository at this point
Copy the full SHA f804e4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6316d66 - Browse repository at this point
Copy the full SHA 6316d66View commit details -
Update cert test dapr/dapr to main with updated io.Closer
Signed-off-by: joshvanl <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 10bde67 - Browse repository at this point
Copy the full SHA 10bde67View commit details -
Adds healthz to runtime config
Signed-off-by: joshvanl <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2b5fbee - Browse repository at this point
Copy the full SHA 2b5fbeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for f711630 - Browse repository at this point
Copy the full SHA f711630View commit details -
Fix nil Security on runtime config
Signed-off-by: joshvanl <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4e934bc - Browse repository at this point
Copy the full SHA 4e934bcView commit details -
Adds unit tags to certification workflow file
Signed-off-by: joshvanl <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 555ce7f - Browse repository at this point
Copy the full SHA 555ce7fView commit details -
Chain go test tags in workflow
Signed-off-by: joshvanl <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7881ba9 - Browse repository at this point
Copy the full SHA 7881ba9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 702899e - Browse repository at this point
Copy the full SHA 702899eView commit details
Commits on Sep 19, 2024
-
Signed-off-by: joshvanl <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2bb2a06 - Browse repository at this point
Copy the full SHA 2bb2a06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65556ae - Browse repository at this point
Copy the full SHA 65556aeView commit details -
Adds
Close() error
to echo conversationSigned-off-by: joshvanl <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for db30576 - Browse repository at this point
Copy the full SHA db30576View commit details