Fixes for SQL Server state store #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
|
There seems to still be a bug where existing keys are not updated and this is appearing only now for some reason. @JoshVanL could you please take a look and see what's going on? You can see in the tests that calling |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: joshvanl <[email protected]>
sqlserver: Remove upsert conditionals
…nto fix-sqlserver
Signed-off-by: ItalyPaleAle <[email protected]>
|
/ok-to-test |
Components conformance testCommit ref: 11d4acc ✅ All conformance tests passedAll tests have reported a successful status |
Components certification testCommit ref: 11d4acc ❌ Some certification tests failedThese tests failed:
|
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 11d4acc |
artursouza
previously approved these changes
Jun 19, 2023
|
@ItalyPaleAle @artursouza Can we open this against 1.11 instead and then merge back to master? |
berndverst
approved these changes
Jun 19, 2023
berndverst
pushed a commit
to berndverst/components-contrib
that referenced
this pull request
Jun 19, 2023
Signed-off-by: Bernd Verst <[email protected]>
ItalyPaleAle
added a commit
that referenced
this pull request
Jun 20, 2023
Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SQL Server certification tests and integration tests.
I had to manually delete the stored procedure that existed in the test database (and have it re-created) since it seems it was stuck at an old version