Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1023: Add default port for http grpc #1304

Closed

Conversation

shivam-51
Copy link
Contributor

@shivam-51 shivam-51 commented Jun 6, 2023

Description

Add default ports for HTTP and gRPC for dapr run.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1023

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@shivam-51 shivam-51 requested review from a team as code owners June 6, 2023 06:49
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #1304 (44ce918) into master (a4f924f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1304   +/-   ##
=======================================
  Coverage   26.82%   26.82%           
=======================================
  Files          39       39           
  Lines        3881     3881           
=======================================
  Hits         1041     1041           
  Misses       2766     2766           
  Partials       74       74           
Impacted Files Coverage Δ
pkg/standalone/run.go 0.00% <ø> (ø)

@mukundansundar
Copy link
Collaborator

@shivam-51 can you fix the conflicts in this PR?

Signed-off-by: Shivam Kumar Singh <[email protected]>
Signed-off-by: Shivam Kumar Singh <[email protected]>
@shivam-51 shivam-51 force-pushed the 1023-add-default-port-for-http-grpc branch from e7bbadd to 46fdf20 Compare June 12, 2023 08:05
@shivam-51
Copy link
Contributor Author

@shivam-51 can you fix the conflicts in this PR?

Done.

@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added stale and removed stale labels Jul 23, 2023
@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Aug 22, 2023
@dapr-bot
Copy link
Collaborator

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Dapr gRPC port is inconsistent with documentation
3 participants