Addressed Shubham's new comments

Signed-off-by: Mohit Pal Singh <[email protected]>
dapr · Jun 23, 2023 · 29b9c8d · 29b9c8d
1 parent 69f5b56
commit 29b9c8d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/pkg/standalone/standalone.go b/pkg/standalone/standalone.go
@@ -905,7 +905,7 @@ func moveFileToPath(filepath string, installLocation string) (string, error) {
 		p := os.Getenv("PATH")
 
 		if !strings.Contains(strings.ToLower(p), strings.ToLower(destDir)) {
-			utils.SanitizeDir(&destDir)
+			destDir = utils.SanitizeDir(destDir)
 			pathCmd := "[System.Environment]::SetEnvironmentVariable('Path',[System.Environment]::GetEnvironmentVariable('Path','user') + '" + fmt.Sprintf(";%s", destDir) + "', 'user')"
 			_, err := utils.RunCmdAndWait("powershell", pathCmd)
 			if err != nil {

diff --git a/utils/utils.go b/utils/utils.go
@@ -405,6 +405,8 @@ func FindFileInDir(dirPath, fileName string) (string, error) {
 }
 
 // SanitizeDir corrects any syntactical errors in the passed directory.
-func SanitizeDir(destDir *string) {
-	*destDir = strings.Replace(*destDir, "'", "''", -1)
+func SanitizeDir(destDir string) string {
+	correctedDestDir := destDir
+	correctedDestDir = strings.Replace(correctedDestDir, "'", "''", -1)
+	return correctedDestDir
 }