Warn if build non existent #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmyway
force-pushed
the
warn-if-build-non-existent
branch
from
53da631
to
0250f54
Compare
danmyway
force-pushed
the
warn-if-build-non-existent
branch
from
0250f54
to
4a0820b
Compare
* refactor get_info() in copr_api module * add warning, when referenced build is not found in the query * modify reference and build_id nargs to accept only one option * warn and exit when build_id doesnt point to correct project/package and/or the state of the build is failed Signed-off-by: Daniel Diblik <[email protected]>
danmyway
force-pushed
the
warn-if-build-non-existent
branch
from
4a0820b
to
218d356
Compare
Signed-off-by: Daniel Diblik <[email protected]>
danmyway
force-pushed
the
warn-if-build-non-existent
branch
from
218d356
to
9576536
Compare
danmyway
added a commit
that referenced
this pull request
Mar 25, 2024
* Refactor copr_api, modify nargs * refactor get_info() in copr_api module * add warning, when referenced build is not found in the query * modify reference and build_id nargs to accept only one option * warn and exit when build_id doesn't point to correct project/package and/or the state of the build is failed * Add docstring, append changelog Signed-off-by: Daniel Diblik <[email protected]> --------- Signed-off-by: Daniel Diblik <[email protected]>
danmyway
added a commit
that referenced
this pull request
Mar 25, 2024
* PoC leapp copr * can find package and build the dict for leapp Signed-off-by: Daniel Diblik <[email protected]> * PoC workable state * copr and brew build testing supported for leapp-repository, not documented Signed-off-by: Daniel Diblik <[email protected]> * Refactor report table generation * Update issue templates (#29) * Add github workflows (#30) * add label commenter for issues and PR's Signed-off-by: Daniel Diblik <[email protected]> * Fix install (#32) * Fix entrypoint, add main * add main() function to tesar/__main__ * bumb version * fix url in setup.py Signed-off-by: Daniel Diblik <[email protected]> * Fix packaging - Instead of setup.py a setup.cfg and pyproject.toml have been introduced; - Added __init__.py to the tesar module Ideally I'd personally not have dispatch and report as separate packages, but rather have them part of tesar module, but for the moment let's make minimally invasive changes and just focus on making tesar installable. Closes: #27 --------- Signed-off-by: Daniel Diblik <[email protected]> Co-authored-by: Daniel Diblik <[email protected]> * hotfix/Fix not assigned variables (#34) * source_release and target_release were not assigned for dispatching c2r test jobs Signed-off-by: Daniel Diblik <[email protected]> * Make -c option append test results (#26) * Make -c option append test results Instead of having -c accept a list of tests like '-c test1 test2 test3' let's have a more natural way of '-c test1 -c test2 -c test3'. Covered by a unit test. Closes: #23 * Move code under src/ directory - Change has been reflected in setup.cfg; - setup.py introduced, removed pyproject.toml for now OAMG-9529 * Some refactoring - COMPOSE_MAPPING variable autoloading based on cli options upon dispatch module load removed. Now the code that needs access to COMPOSE_MAPPING will load it on-demand via dispatch.get_compose_mapping method. - dispatch global variables have been moved out to dispatch_globals.py OAMG-9529 * Make tests runnable by tox Now a single `tox` command will build&run unit tests under tests/ directory. OAMG-9529 * Introduce a unit-tests github action Shamelessly borrowed as is from the official docs https://docs.github.com/en/actions/automating-builds-and-tests/ * Update changelog and readme * Fix missing libkrb5 in unit-tests github action This should help with failures upon package installation in the tox env. * Run main function in __main__ (#44) Also move the main definition to __init__. The purpose of the __main__ is to be executed when the module is executed via python -m tesar. * Bump targets in dispatch_globals * bump OL latest target to 8.8 * update the distro context Signed-off-by: Daniel Diblik <[email protected]> * Bump to Alma and Rocky to 8.9 * bump targets, keep EUS (8.6, 8.8) Signed-off-by: Daniel Diblik <[email protected]> * Update Changelog and README Signed-off-by: Daniel Diblik <[email protected]> * Handle no target specified for leapp-repository * When no target was specified for leapp-repository the utility failed to parse None type objects * Handle the same way as for c2r, when no target specified dispatch for all mapped targets/upgrade paths * add docstring Fixes #36 Signed-off-by: Daniel Diblik <[email protected]> * Treat overall result as single value * Return code for report * New option to skip passed results * Don't create logs directory when the result is skipped * Add debug messages to report command Those debug messages also serve as comments describing what's happening in the code. * Add forgotten import * Workaround missing xunit This commit fixes 'tesar report' in case the json on api-dev.testing-farm.io is missing the xml in the xunit field. The results are pulled from artifacts/results.xml file. * Introduce 2 test runs comparison mode Currently 2 modes are possible (switch is controlled by --level2 argument) - show plans-list comparison or detailed tests-list comparison. Some additional arguments to the tesar report command have been added: * comparison is triggered with --compare flag * you can use -u/--unify_results to combine several plan results for comparison. Can be useful if you are comparing 2 runs where tests have been renamed. To try out comparison: tesar report -c 9b44f3a9-dd92-46c4-9606-5396b1771753 -c 4e304b84-8ffb-49f2-8be9-1c3d8953ab03 --short --level2 --unify tier0_7to8=tier0 --compare * Add docstrings to newly introduced functions Also CHANGELOG and README have information about `tesar report --compare` now. * Hotfix update reval and continue if not xunit * patch #57 Signed-off-by: Daniel Diblik <[email protected]> * Add --showarch option to report command This option adds new Arch column to the report table. * Make --skip-pass respected by test comparison mode Let's fix this slight oversight so that tesar report --compare --skip-pass will be showing only problematic results. * Add provision UEFI option (#62) * `-u/--uefi` to request UEFI target if available Signed-off-by: Daniel Diblik <[email protected]> * Bump parallel limit, add centos stream (#67) * bump the limit for plans run in parallel to 42 ** add cli option to override the default * add CentOS stream to targets Signed-off-by: Daniel Diblik <[email protected]> * Accept testfilter and/or planfilter with plan option (#64) * Previously the filters were mutually exclusive, which is unusable if one needs to specify one test ouf of many inside a plan * make the filters compatible * if the plans argument has more than one value with additional filters, exit Signed-off-by: Daniel Diblik <[email protected]> * Warn if build non existent (#35) * Refactor copr_api, modify nargs * refactor get_info() in copr_api module * add warning, when referenced build is not found in the query * modify reference and build_id nargs to accept only one option * warn and exit when build_id doesn't point to correct project/package and/or the state of the build is failed * Add docstring, append changelog Signed-off-by: Daniel Diblik <[email protected]> --------- Signed-off-by: Daniel Diblik <[email protected]> * Add specfile and packit.yaml (#68) * Fix broken requirements * remove envparse listed as requirement, but not used anywhere * Refactor dir hierarchy * Push devel builds to the devel repository * Fix imports * fix tests * changelog, readme modifications Signed-off-by: Daniel Diblik <[email protected]> * Fix IndexError with unexpected xml (#71) * fixes #70 * bail out when the xml yields just one entry with name pipeline and overall result error * try request overall result if xml unavailable Signed-off-by: Daniel Diblik <[email protected]> * Bumb version, changelog Signed-off-by: Daniel Diblik <[email protected]> --------- Signed-off-by: Daniel Diblik <[email protected]> Co-authored-by: Pavel Holica <[email protected]> Co-authored-by: ina vasilevskaya <[email protected]> Co-authored-by: ina vasilevskaya <[email protected]> Co-authored-by: Michal Macura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and/or the state of the build is failed
Fixes #33, #51