Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some dependencies #366

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Update some dependencies #366

merged 3 commits into from
Nov 9, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 8, 2023

No description provided.

@jwodder jwodder added the dependencies Pull requests that update a dependency file label Nov 8, 2023
@jwodder
Copy link
Member Author

jwodder commented Nov 8, 2023

@yarikoptic Did something about the DANDI_API_KEY secret used to authenticate with staging change a couple weeks ago? Recent tests in CI have been failing with "401 Unauthorized" errors.

@yarikoptic
Copy link
Member

@yarikoptic Did something about the DANDI_API_KEY secret used to authenticate with staging change a couple weeks ago? Recent tests in CI have been failing with "401 Unauthorized" errors.

oh, if it was "mine" -- I think I have regenerated it! Let me update it... (will look into registering with dandibot...)

@yarikoptic
Copy link
Member

I have updated to a new key, now associated with dandibot account.

@jwodder
Copy link
Member Author

jwodder commented Nov 8, 2023

@yarikoptic Secret updated.

@jwodder
Copy link
Member Author

jwodder commented Nov 8, 2023

@yarikoptic Now the tests are getting "403 Forbidden" when trying to delete Dandiset versions (Does that require admin privileges?).

@yarikoptic
Copy link
Member

correct! only admin can delete released versions. Please re-try now ;)

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (744de47) 75.90% compared to head (150d1fb) 75.90%.
Report is 12 commits behind head on draft.

Additional details and impacted files
@@           Coverage Diff           @@
##            draft     #366   +/-   ##
=======================================
  Coverage   75.90%   75.90%           
=======================================
  Files          14       14           
  Lines        2548     2548           
  Branches      568      568           
=======================================
  Hits         1934     1934           
  Misses        451      451           
  Partials      163      163           
Files Coverage Δ
tools/backups2datalad/aioutil.py 73.23% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder
Copy link
Member Author

jwodder commented Nov 8, 2023

@yarikoptic Tests pass now.

@yarikoptic yarikoptic merged commit 0758976 into draft Nov 9, 2023
7 checks passed
@yarikoptic yarikoptic deleted the updates branch November 9, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants