Fix host used in minio URLs #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1487 +/- ##
==========================================
+ Coverage 88.54% 88.62% +0.07%
==========================================
Files 77 77
Lines 10565 10565
==========================================
+ Hits 9355 9363 +8
+ Misses 1210 1202 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yarikoptic
reviewed
Aug 15, 2024
| @@ -29,7 +29,7 @@ services: | |||
| DJANGO_MINIO_STORAGE_ENDPOINT: minio:9000 | |||
| DJANGO_MINIO_STORAGE_SECRET_KEY: minioSecretKey | |||
| DJANGO_STORAGE_BUCKET_NAME: django-storage | |||
| DJANGO_MINIO_STORAGE_MEDIA_URL: http://localhost:9000/django-storage | |||
| DJANGO_MINIO_STORAGE_MEDIA_URL: http://127.0.0.1:9000/django-storage | |||
There was a problem hiding this comment.
it is odd that it would need it for MINIO but nothing else... but ok, if that resolves it for you I do not mind, but please add a brief comment above on why it is needed. ATM not even commit message provides an explanation -- would be hard to figure out why it was needed and thus might get reverted etc.
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
localhostwas causing test failures for me locally when fsspec was involved, likely due tolocalhostalso resolving to::1, which the minio port was not exposed on.