Xfail flaky ontobee tests, unless running daily tests #1423
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1423 +/- ##
==========================================
+ Coverage 67.96% 68.11% +0.15%
==========================================
Files 77 77
Lines 10523 10529 +6
==========================================
+ Hits 7152 7172 +20
+ Misses 3371 3357 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dandi/tests/test_metadata.py
Outdated
| reason="Flaky ontobee site", | ||
| strict=False, | ||
| raises=requests.RequestException, | ||
| ) |
There was a problem hiding this comment.
could you please place this into @mark.xfail_ontobee similarly to @mark.skipif_no_network to avoid duplication/clutter?
There was a problem hiding this comment.
@jwodder ping on this one so we could bring our tests back into greenland
There was a problem hiding this comment.
@yarikoptic The custom mark machinery only seems to support custom skipif decorators, not xfail. I think creating a custom mark.xfail_ontobee would be more trouble than it's worth.
There was a problem hiding this comment.
Hmm, ok
What about just binding decorator into a helper "variable" eg @mark_xfail_ontobee or that wouldn't work?
There was a problem hiding this comment.
It seems to work, but now the tests are failing due to #1424.
There was a problem hiding this comment.
ok, since seems to be unrelated -- let's proceed. Thank you @jwodder
|
🚀 PR was released in |
Closes #1422.