Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yarl to clean up some code #1415

Merged
merged 3 commits into from
Mar 6, 2024

Add tests for `is_same_url()`

e58df62
Select commit
Loading
Failed to load commit list.
Merged

Use yarl to clean up some code #1415

Add tests for `is_same_url()`
e58df62
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 5, 2024 in 0s

68.09% (-20.44%) compared to 2cafb50

View this Pull Request on Codecov

68.09% (-20.44%) compared to 2cafb50

Details

Codecov Report

Attention: Patch coverage is 72.41379% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 68.09%. Comparing base (2cafb50) to head (e58df62).
Report is 3 commits behind head on master.

Files Patch % Lines
dandi/utils.py 62.50% 6 Missing ⚠️
dandi/dandiapi.py 66.66% 1 Missing ⚠️
dandi/tests/test_delete.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1415       +/-   ##
===========================================
- Coverage   88.53%   68.09%   -20.44%     
===========================================
  Files          77       77               
  Lines       10527    10522        -5     
===========================================
- Hits         9320     7165     -2155     
- Misses       1207     3357     +2150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.