Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zarr_checksum dependency to ~= 0.4.0 #1393

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Update zarr_checksum dependency to ~= 0.4.0 #1393

merged 1 commit into from
Jan 24, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jan 23, 2024

No description provided.

@jwodder jwodder added the dependencies Update one or more dependencies version label Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (523f758) 88.50% compared to head (766ef11) 88.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1393      +/-   ##
==========================================
+ Coverage   88.50%   88.59%   +0.08%     
==========================================
  Files          77       77              
  Lines       10492    10492              
==========================================
+ Hits         9286     9295       +9     
+ Misses       1206     1197       -9     
Flag Coverage Δ
unittests 88.59% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder marked this pull request as ready for review January 23, 2024 20:15
@yarikoptic
Copy link
Member

why specifically that new version if no changes to the code which uses it?

@jwodder
Copy link
Member Author

jwodder commented Jan 23, 2024

@yarikoptic It removes some heavy dependencies from dandi-cli's dependency tree.

@yarikoptic
Copy link
Member

I get that, but

  • for new user -- it would already install newer lighter version
  • for existing user -- it would do nothing besides updating zarr_checksum -- those dependencies are already installed and would not even be removed.

so what is the point?

@jwodder
Copy link
Member Author

jwodder commented Jan 23, 2024

@yarikoptic

for new user -- it would already install newer lighter version

No, it wouldn't. dandi-cli's current master commit depends on zarr_checksum ~= 0.3.2, which has an upper bound of < 0.4.0.

Another point in favor of this change: zarr_checksum's dependency on boto3 has twice caused dependency issues with backups2datalad and its aiobotocore dependency. In order to permanently avoid this problem, zarr_checksum must be updated to 0.4.0+ for both backups2datalad and dandi (the latter being a dependency of backups2datalad).

@yarikoptic
Copy link
Member

No, it wouldn't. dandi-cli's current master commit depends on zarr_checksum ~= 0.3.2, which has an upper bound of < 0.4.0.

for that I guess we would have needed zarr_checksum >= 0.3.2,<0.5 or alike... but ok, if you insist and think that it would make a world a better place for us -- let's proceed.

@yarikoptic yarikoptic merged commit 96c3953 into master Jan 24, 2024
28 checks passed
@yarikoptic yarikoptic deleted the up-zarr-chk branch January 24, 2024 01:27
Copy link

github-actions bot commented Feb 2, 2024

🚀 PR was released in 0.59.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants