dandi download dandi://…/dandiset.yaml now downloads dandiset.yaml
#1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1384 +/- ##
==========================================
+ Coverage 88.50% 88.58% +0.08%
==========================================
Files 77 77
Lines 10471 10480 +9
==========================================
+ Hits 9267 9284 +17
+ Misses 1204 1196 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thank you @jwodder ! |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1383.
Note that this feature only applies to
dandi://URLs, as GUI and API URLs cannot refer to a specific asset by path in the first place.Note that this re-interpretation of
dandi://URLs only happens when downloading and not when adandi://…/dandiset.yamlURL is supplied to amove,delete,ls, orreextract-metadatacommand (I think those are all the places thatdandi://URLs are accepted), as it wouldn't make sense for most of those.