?location parameter in URLs can only point to a folder
#1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwodder
changed the title
?location parameter in URLs can only point to folders
jwodder
added
minor
jwodder
changed the title
?location parameter in URLs can only point to folders?location parameter in URLs can only point to a folder
jwodder
force-pushed
the
enh-location-folder
branch
from
69ac203
to
9007788
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1305 +/- ##
=======================================
Coverage 88.78% 88.78%
=======================================
Files 76 76
Lines 10216 10220 +4
=======================================
+ Hits 9070 9074 +4
Misses 1146 1146
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
@yarikoptic Done. |
yarikoptic
commented
Jun 15, 2023
…to the folder Per @AlmightyYakob observation in dandi/dandi-archive#1546 (comment)
yarikoptic
force-pushed
the
enh-location-folder
branch
from
2460935
to
24901a9
Compare
8 type checking errors all seems to relate to changed requests "API" and to be addressed in https://github.com//pull/13362023-10-20T16:01:19.7395937Z typing: commands[0]> mypy dandi
2023-10-20T16:01:35.3761604Z dandi/dandiapi.py:251: error: Item "None" of "Optional[Response]" has no
2023-10-20T16:01:35.3764882Z attribute "status_code" [union-attr]
2023-10-20T16:01:35.3861802Z e.response.status_code,
2023-10-20T16:01:35.3862427Z ^~~~~~~~~~~~~~~~~~~~~~
2023-10-20T16:01:35.3863374Z dandi/dandiapi.py:254: error: Item "None" of "Optional[Response]" has no
2023-10-20T16:01:35.3864704Z attribute "text" [union-attr]
2023-10-20T16:01:35.3865208Z e.response.text,
2023-10-20T16:01:35.3865952Z ^~~~~~~~~~~~~~~
2023-10-20T16:01:35.3866822Z dandi/files/bases.py:365: error: Item "None" of "Optional[Response]" has no
2023-10-20T16:01:35.3867678Z attribute "status_code" [union-attr]
2023-10-20T16:01:35.3868292Z if e.response.status_code == 409:
2023-10-20T16:01:35.3869179Z ^~~~~~~~~~~~~~~~~~~~~~
2023-10-20T16:01:35.3870091Z dandi/files/bases.py:367: error: Item "None" of "Optional[Response]" has no
2023-10-20T16:01:35.3870953Z attribute "headers" [union-attr]
2023-10-20T16:01:35.3871699Z blob_id = e.response.headers["Location"]
2023-10-20T16:01:35.3872486Z ^~~~~~~~~~~~~~~~~~
2023-10-20T16:01:35.3873254Z dandi/files/zarr.py:302: error: Item "None" of "Optional[Response]" has no
2023-10-20T16:01:35.3874325Z attribute "text" [union-attr]
2023-10-20T16:01:35.3875873Z if "Zarr already exists" in e.response.text:
2023-10-20T16:01:35.3876611Z ^~~~~~~~~~~~~~~
2023-10-20T16:01:35.5375668Z dandi/dandiarchive.py:168: error: Item "None" of "Optional[Response]" has no
2023-10-20T16:01:35.5377058Z attribute "status_code" [union-attr]
2023-10-20T16:01:35.5377915Z if e.response.status_code == 401 and authenticate is n...
2023-10-20T16:01:35.5379166Z ^~~~~~~~~~~~~~~~~~~~~~
2023-10-20T16:01:35.5380197Z dandi/dandiarchive.py:296: error: Item "None" of "Optional[Response]" has no
2023-10-20T16:01:35.5381093Z attribute "status_code" [union-attr]
2023-10-20T16:01:35.5382293Z if e.response.status_code == 401 and authenticate is n...
2023-10-20T16:01:35.5383660Z ^~~~~~~~~~~~~~~~~~~~~~
2023-10-20T16:01:35.8677309Z dandi/download.py:703: error: Item "None" of "Optional[Response]" has no
2023-10-20T16:01:35.8678560Z attribute "status_code" [union-attr]
2023-10-20T16:01:35.8679978Z if attempt >= 2 or exc.response.status_code not in (
2023-10-20T16:01:35.8680963Z ^~~~~~~~~~~~~~~~~~~~~~~~
2023-10-20T16:01:37.0146976Z Found 8 errors in 5 files (checked 78 source files)
2023-10-20T16:01:37.0358546Z typing: exit 1 (17.30 seconds) /home/runner/work/dandi-cli/dandi-cli> mypy dandi pid=2094 |
|
3.10 and 3.11 fails are known test_update_dandiset_from_doi . let's proceed |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @AlmightyYakob observation in
dandi/dandi-archive#1546 (comment)
If you don't see a problem with such an approach, please finish it up (leaner code if any , tests) @jwodder so we could declare that issue in the archive addressed.
Closes #1256