Skip to content

Commit

Permalink
Fix wait_until_valid to properly wait for a publishable version
Browse files Browse the repository at this point in the history
  • Loading branch information
danlamanna committed Jul 18, 2023
1 parent 4cde72f commit 682a150
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dandi/dandiapi.py
Original file line number Diff line number Diff line change
Expand Up @@ -1023,7 +1023,7 @@ def wait_until_valid(self, max_time: float = 120) -> None:
start = time()
while time() - start < max_time:
v = self.get_version(self.version_id)
if v.status is VersionStatus.VALID:
if v.status is VersionStatus.VALID and not v.asset_validation_errors:

Check warning on line 1026 in dandi/dandiapi.py

View check run for this annotation

Codecov / codecov/patch

dandi/dandiapi.py#L1026

Added line #L1026 was not covered by tests
return
sleep(0.5)
# TODO: Improve the presentation of the error messages
Expand Down

0 comments on commit 682a150

Please sign in to comment.