add external neurosift service for .nwb.lindi.tar #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waxlamp
reviewed
Sep 20, 2024
Comment on lines
362
to
367
| { | ||
| name: 'Neurosift', | ||
| regex: /\.nwb.lindi.tar$/, | ||
| maxsize: Infinity, | ||
| endpoint: 'https://neurosift.app?p=/nwb&url=$asset_dandi_url$&st=lindi&dandisetId=$dandiset_id$&dandisetVersion=$dandiset_version$', // eslint-disable-line max-len | ||
| }, |
There was a problem hiding this comment.
Since this is exactly the same as the previous Neurosift spec but for the file extension, would it make sense to simply update the regex in line 357 to accept both .nwb.lindi.json and .nwb.lindi.tar?
|
Not sure why that e2e puppeteer test is failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small update enables external Neurosift links for assets with the .nwb.lindi.tar file extension. Support for the .nwb.lindi.json extension was previously added in #1922.
Background
For more information on the purpose of lindi, and why both .lindi.json and .lindi.tar extensions are necessary, please refer to the Lindi repository.
Next Steps
Currently, I plan to upload lindi files only to the staging site, as Lindi is not yet officially supported. Over the coming weeks, I will be working on making a case for future DANDI support, and look forward to discussion on the topic. I know there are issues about avoiding broken references.
In the meantime, having this menu option functional would be highly beneficial to me. Specifically, I will be presenting at a workshop next Thursday, and it would be convenient to have this feature available by then, although I could make do without it.