add trackOnce parameter to setProgress #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing 👍 This is a great addition to the project. To make your pull request complete, could you please add/modify the tests and update the documentation? |
…d in the track() call.
guiann
force-pushed
the
setProgress-trackOnce
branch
from
79a225d
to
a3c1690
Compare
|
done. |
Rapha0511
reviewed
Oct 19, 2023
…trasmited in the track() call." This reverts commit a3c1690.
|
a3c1690 reverted. |
|
LGTM ! |
Rapha0511
approved these changes
Nov 9, 2023
ZacharieTFR
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add a parameter in VASTTracker.setProgress()
to avoid sending event once for all in case we want to send quartile events several times.
Issue
Issue Link : issues/460
Type