Fix/Handle duplicate VASTAdTagURI in AdPod #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacharieTFR
reviewed
Aug 23, 2023
spec/vast_parser.spec.js
Outdated
Comment on lines
89
to
90
| done(); | ||
| expect(urlHandlerSpy).toHaveBeenCalledWith( |
There was a problem hiding this comment.
You might want to put the done after the expect as Jest do in their documentation https://jestjs.io/docs/asynchronous#callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the
parentURLsarray was used to store and check if a VASTAdTagURI has been called before, to prevent multiple calls to the same URL. This array has been removed as it is no longer necessary.Now, wrappers within an AdPod can reference the same VASTAdTagURI. This change is based on the consideration that, in case where a wrapper is calling itself, the fetching process will stop after the
maxWrapperDepthis reached. This mechanism prevents infinite loops.Issue
#450
Type