fix: connection leaks #624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you. |
mzz2017
changed the title
|
❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you. |
mzz2017
force-pushed
the
mzz/fix_dial_context
branch
from
eed06b3
to
2ca199c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Many users have reported continuous memory growth in dae, possibly due to coroutine leaks.
This phenomenon is even more obvious when the network is disconnected. A very suspicious object is that our dialer does not implement DialContext, resulting in the timeout mechanism not being triggered when calling down.
This PR attempts to fix this problem.
Checklist
Full Changelogs
Issue Reference
Closes #[issue number]
Test Result