Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/chore: disable gso on client by default and upgrade softwind/quic-go #391

Merged
merged 3 commits into from
Jan 1, 2024

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Dec 31, 2023

Background

Some users reported that enabling GSO on the client would affect the performance of watching YouTube, so we disabled it by default.

Checklist

Full Changelogs

  1. Upgrade quic-go to v0.40.1.
  2. Disable gso on the client by default.

Issue Reference

Related #301

Test Result

image

@mzz2017 mzz2017 requested a review from a team as a code owner December 31, 2023 14:34
@dae-prow dae-prow bot added the chore label Dec 31, 2023
@mzz2017 mzz2017 changed the title chore: upgrade softwind/quic-go chore: upgrade softwind/quic-go and disable gso on client by default Dec 31, 2023
@mzz2017 mzz2017 changed the title chore: upgrade softwind/quic-go and disable gso on client by default fix/chore: upgrade softwind/quic-go and disable gso on client by default Dec 31, 2023
@mzz2017 mzz2017 changed the title fix/chore: upgrade softwind/quic-go and disable gso on client by default fix/chore: disable gso on client by default and upgrade softwind/quic-go Dec 31, 2023
@mzz2017 mzz2017 added the tested label Dec 31, 2023
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@sumire88
Copy link
Contributor

sumire88 commented Jan 1, 2024

Thanks for resolving this known issue!

@mzz2017 mzz2017 merged commit 366fcb1 into main Jan 1, 2024
27 checks passed
@mzz2017 mzz2017 deleted the upgrade_softwind branch January 1, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants