feat: Support <Link /> in Future API
#509
Open
+523
−1,630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 99d4e92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
config/src/Config.ts
Outdated
Comment on lines
2
to
5
| import type { ConfigDefinition } from "./ConfigDefinition"; | ||
|
|
||
| export type Config<T extends ActivityDefinition<string>> = { | ||
| activities: T[]; | ||
| transitionDuration: number; | ||
| initialActivity?: () => T["name"]; | ||
| }; | ||
| export interface Config<T extends ActivityDefinition<string>> | ||
| extends ConfigDefinition<T> {} |
There was a problem hiding this comment.
ConfigDefinition과 Config를 분리합니다
tonyfromundefined
changed the title
<Link /> component<Link /> in Future API
tonyfromundefined
force-pushed
the
add-link-component
branch
from
59b8734
to
6303b62
Compare
orionmiz
reviewed
Sep 23, 2024
기본 동작이 너무 복잡해보여서 제거했어요. 추후에 참고: |
orionmiz
reviewed
Sep 23, 2024
2 tasks
tonyfromundefined
force-pushed
the
add-link-component
branch
from
9e92895
to
99d4e92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
내용
<Link />컴포넌트는@stackflow/plugin-history-sync에 의존하고 있었어요. (import를 함)<Link />컴포넌트는@stackflow/plugin-history-sync에 직접적으로 의존하지 않는 형태에요.@stackflow/plugin-history-sync가 깔려있으면,href="..."를 셋팅하고, 아니면href를 없애면 돼요.app.decorate()방식을 참고했어요.