Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core,react): add targetActivityId property #502

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Conversation

orionmiz
Copy link
Member

@orionmiz orionmiz commented Aug 13, 2024

Disclaimer: targetActivityId seems to be an ambiguous name because the history calibrator is not implemented yet.

Should we support the history calibrator in the future? Otherwise, allowedActivityId would be a more appropriate name.

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Aug 13, 2024 11:32am

Copy link

changeset-bot bot commented Aug 13, 2024

🦋 Changeset detected

Latest commit: 00ff054

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@stackflow/react Minor
@stackflow/core Minor
@stackflow/docs Patch
@stackflow/demo Patch
@stackflow/compat-await-push Patch
@stackflow/link Patch
@stackflow/plugin-basic-ui Patch
@stackflow/plugin-devtools Patch
@stackflow/plugin-google-analytics-4 Patch
@stackflow/plugin-history-sync Patch
@stackflow/plugin-map-initial-activity Patch
@stackflow/plugin-preload Patch
@stackflow/plugin-renderer-basic Patch
@stackflow/plugin-renderer-web Patch
@stackflow/plugin-stack-depth-change Patch
@stackflow/react-ui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@tonyfromundefined tonyfromundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add targetActivityId options in future api

@tonyfromundefined
Copy link
Member

tonyfromundefined commented Aug 14, 2024

How about automatically add targetActivityId from useStepFlow() hook in Future API?

// as-is:
export function useStepFlow() {
  const coreActions = useCoreActions();

  return makeStepActions(() => coreActions);
}
// to-be:
export function useStepFlow() {
  const coreActions = useCoreActions();
  const activity = useActivity();

  return makeStepActions(() => coreActions, () => activity);
}

@orionmiz orionmiz merged commit 667570b into main Aug 14, 2024
4 checks passed
@orionmiz orionmiz deleted the step-target-activity branch August 14, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants