-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core,react): add targetActivityId
property
#502
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 00ff054 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add targetActivityId
options in future api
How about automatically add // as-is:
export function useStepFlow() {
const coreActions = useCoreActions();
return makeStepActions(() => coreActions);
} // to-be:
export function useStepFlow() {
const coreActions = useCoreActions();
const activity = useActivity();
return makeStepActions(() => coreActions, () => activity);
} |
Disclaimer:
targetActivityId
seems to be an ambiguous name because the history calibrator is not implemented yet.Should we support the history calibrator in the future? Otherwise,
allowedActivityId
would be a more appropriate name.