Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Solid integration #473

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: add Solid integration #473

wants to merge 4 commits into from

Conversation

XiNiHa
Copy link
Contributor

@XiNiHa XiNiHa commented Jul 4, 2024 •
edited
Loading

Related: #277

Tasks

  • Port integration
  • Port plugin-renderer-basic
  • Port plugin-renderer-web
  • Port plugin-basic-ui
  • Port demo app
  • Port plugin-history-sync
    • Fix broken typecheck when skipLibCheck: false and either @stackflow/react or @stackflow/solid is missing
  • Port plugin-map-initial-activity the implementation was actually not React-specific at all
  • Port plugin-preload
  • Port link
  • Port plugin-google-analytics-4
  • Update docs
  • Port future APIs

All concerns mentioned in the comment should be resolved before merging.

Future works

  • Add SolidStart filesystem router integration

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b13619d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jul 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Aug 30, 2024 2:51am

@tonyfromundefined tonyfromundefined requested review from tonyfromundefined and orionmiz and removed request for tonyfromundefined July 8, 2024 05:55
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch 2 times, most recently from 5af2e4a to 7ca33e4 Compare July 18, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orionmiz orionmiz Awaiting requested review from orionmiz

@tonyfromundefined tonyfromundefined Awaiting requested review from tonyfromundefined

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@XiNiHa